NotificationsYou must be signed in to change notification settings
Fork8.1k
Star22.1k

Updated offsetbox.py#26880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Anjini2004 wants to merge1 commit intomatplotlib:mainfromAnjini2004:patch-3

Closed

Updated offsetbox.py#26880

Anjini2004 wants to merge1 commit intomatplotlib:mainfromAnjini2004:patch-3

Conversation

Copy link

Anjini2004 commentedSep 22, 2023

PR summary

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

Updated offsetbox.py

b084658

Copy link

Member

ksunden commentedSep 22, 2023

Thank you for your pull request!

Since these methods are fully deprecated, their implementation should also be removed.

Here are the deprecation notes that you can slightly reword to reflect removal rather than deprecation (they can both appear in the same file):

matplotlib/doc/api/prev_api_changes/api_changes_3.7.0/deprecations.rst

Line 191 in04e1332

``OffsetBox.get_extent_offsets`` and ``OffsetBox.get_extent``

matplotlib/doc/api/prev_api_changes/api_changes_3.7.0/deprecations.rst

Line 211 in04e1332

``offsetbox.bbox_artist``

github-actionsbot reviewed

Sep 22, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

QuLogic reviewed

Sep 22, 2023

View reviewed changes

Copy link

Member

QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The entirety of the functions marked with_api.deprecated should be removed.

QuLogic added mentored: hackathon Maintenance labels

Sep 22, 2023

QuLogic added this to thev3.9.0 milestone

Sep 22, 2023

Copy link

Member

tacaswell commentedSep 22, 2023

xref#26865

tacaswell requested changes

Sep 22, 2023

View reviewed changes

Copy link

Member

tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Need to remove the deprecated method and add a API change note.

Copy link

Member

ksunden commentedSep 25, 2023

Thanks again for the pull request, however, looks like the required changes for this deprecation got merged in#26910, so unfortunately I am going to close this version. Thank you for your interest and we hope to hear from you again!