NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Cleaned up the span_where class method from Polycollections.#26874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 1 commit intomatplotlib:mainfromagautam478:collections

Sep 27, 2023

Merged

Cleaned up the span_where class method from Polycollections.#26874

QuLogic merged 1 commit intomatplotlib:mainfromagautam478:collections

Sep 27, 2023

Conversation

Copy link

Contributor

agautam478 commentedSep 22, 2023

PR summary

This PR removes the deprecated code during the version 3.7 from lib/matplotlib/collection.py which is a sub issue in the parent issues here:#26865

PR checklist

[ N/A] "closes #0000" is in the body of the PR description tolink the related issue
[ N/A] new and changed code istested
[ N/A]Plotting related features are demonstrated in anexample
[ N/A]New Features andAPI Changes are noted with adirective and release note
[ N/A] Documentation complies withgeneral anddocstring guidelines

QuLogic reviewed

Sep 22, 2023

View reviewed changes

doc/api/next_api_changes/removals/26874-AG.rst OutdatedShow resolvedHide resolved

QuLogic reviewed

Sep 22, 2023

View reviewed changes

doc/api/next_api_changes/removals/26874-AG.rst OutdatedShow resolvedHide resolved

QuLogic added mentored: hackathon Maintenance labels

Sep 22, 2023

tacaswell added this to thev3.9.0 milestone

Sep 22, 2023

tacaswell reviewed

Sep 22, 2023

View reviewed changes

lib/matplotlib/collections.py Outdated

		"the compressed values is deprecated. "
		"Pass the full 2D shape of the original array "
		f"{prev_unmask.shape} including the masked elements.")
		"the compressed values is deprecated. "

Copy link

Member

tacaswellSep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Were these changes intentional?

Copy link

ContributorAuthor

agautam478Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The pep8 linter fixed the sapcings.

Copy link

Member

QuLogic commentedSep 22, 2023

Linting shows that there is a little more fallout from this removal:

An import ofBrokenBarHCollection inlib/matplotlib/axes/_axes.pyi andlib/matplotlib/pyplot.py
A doc reference indoc/users/prev_whats_new/whats_new_1.4.rst; this should be changed to code style (remove the:class: and change the single back ticks to double backticks).
Inlib/matplotlib/axes/_axes.pyi andlib/matplotlib/pyplot.py,broken_barh is typed as returningBrokenBarHCollection; this iswrong and should be changed toPolyCollection.

Copy link

Member

QuLogic commentedSep 22, 2023

Sorry, there is one more remaining instance in the docs atdoc/api/artist_api.rst.

Copy link

ContributorAuthor

agautam478 commentedSep 25, 2023•
edited
Loading

yayy! finally the build passed. 👯
Thanks@QuLogic for the review.

QuLogic reviewed

Sep 25, 2023

View reviewed changes

doc/users/prev_whats_new/whats_new_1.4.rst

		@@ -221,7 +221,6 @@ Added size related functions to specialized `.Collection`\s
		Added the ``get_size`` and ``set_size`` functions to control the size of
		elements of specialized collections (
		:class:`~matplotlib.collections.AsteriskPolygonCollection`
		:class:`~matplotlib.collections.BrokenBarHCollection`

Copy link

Member

QuLogicSep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This shouldn't be removed from old docs, even though it doesn't exist any more, because it's a historical reflection of "what's new in 1.4". Mark it as code style instead:

Suggested change