Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Backport PR #26849 on branch v3.8.x (Bump setuptools required version because of setuptools_scm v8)#26860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR#26849: Bump setuptools required version because of setuptools_scm v8

@lumberbot-applumberbot-appbot added this to thev3.8.1 milestoneSep 21, 2023
@tacaswell
Copy link
Member

I'm 50/50 on actually merging this.

@ksunden
Copy link
Member

I think we probably need to either merge this or potentially do a pin onsetuptools_scm for this branch, otherwise all backport PRs will fail Azure CI, which may make realizing real failures on backport harder.

Wecould go an alternative route of not pinning but explicitly installing newer setuptools which would unbreak CI but could leave a thorny path for people installing from source on the backport branch (That's one of the main reasons I just pinned on main)

But doing that would not (officially) be a development/version support change on a point release, though in practice there issome added constraint in compatibility (though unfortunately only flagged/enforced at runtime)

@tacaswell
Copy link
Member

I am less worried about the numpy build time issues than I am by overly pinning deps.

This also only matters for source installations?

@QuLogic
Copy link
Member

It is breaking CI on other backports:#26939

@ksunden
Copy link
Member

Yes, it only matters for source installations (but that includes CI)

@efiringefiring merged commitcc2f0e3 intomatplotlib:v3.8.xOct 4, 2023
@efiring
Copy link
Member

Seems very low risk; let's try it, to get things moving again.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.8.1
Development

Successfully merging this pull request may close these issues.

5 participants
@meeseeksmachine@tacaswell@ksunden@QuLogic@efiring

[8]ページ先頭

©2009-2025 Movatter.jp