Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Backport PR #26849 on branch v3.8.x (Bump setuptools required version because of setuptools_scm v8)#26860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…e of setuptools_scm v8
I'm 50/50 on actually merging this. |
I think we probably need to either merge this or potentially do a pin on Wecould go an alternative route of not pinning but explicitly installing newer setuptools which would unbreak CI but could leave a thorny path for people installing from source on the backport branch (That's one of the main reasons I just pinned on main) But doing that would not (officially) be a development/version support change on a point release, though in practice there issome added constraint in compatibility (though unfortunately only flagged/enforced at runtime) |
I am less worried about the numpy build time issues than I am by overly pinning deps. This also only matters for source installations? |
It is breaking CI on other backports:#26939 |
Yes, it only matters for source installations (but that includes CI) |
Seems very low risk; let's try it, to get things moving again. |
Backport PR#26849: Bump setuptools required version because of setuptools_scm v8