Movatterモバイル変換

Skip to content

matplotlib/matplotlibPublic

NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Widgets: Remove deprecations and make arguments keyword only#26853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

anntzer merged 1 commit intomatplotlib:mainfromoscargus:widgetdeprecationremovals

Sep 24, 2023

Merged

Widgets: Remove deprecations and make arguments keyword only#26853

anntzer merged 1 commit intomatplotlib:mainfromoscargus:widgetdeprecationremovals

Sep 24, 2023

Conversation

oscargus

Copy link

Member

oscargus commentedSep 21, 2023•
edited
Loading

PR summary

PR checklist

[N/A] "closes #0000" is in the body of the PR description tolink the related issue
[N/A] new and changed code istested
[N/A]Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
[N/A] Documentation complies withgeneral anddocstring guidelines

@oscargus

oscargus added API: changes topic: widgets/UI labels

@oscargus

oscargus changed the title~~Remove deprecations and make arguments keyword only~~Widgets: Remove deprecations and make arguments keyword only

@oscargus

oscargus force-pushed thewidgetdeprecationremovals branch 4 times, most recently from08d9e2c to989dda7Compare

September 21, 2023 08:44

@oscargus

oscargus added this to thev3.9.0 milestone

@oscargus

oscargus force-pushed thewidgetdeprecationremovals branch 4 times, most recently from2e37748 toe19633fCompare

September 21, 2023 19:14

@QuLogic

Copy link

Member

QuLogic commentedSep 21, 2023

@oscargus do you mind holding off on any other deprecation removals? We would like to leave that as a good first issue for the sprint tomorrow.

@oscargus

Copy link

MemberAuthor

oscargus commentedSep 21, 2023

Sure, no problems! Didn't know that.

@QuLogic

QuLogic mentioned this pull request

[MNT]: Remove 3.7-deprecated API#26865

Closed

14 tasks

@QuLogic

Copy link

Member

QuLogic commentedSep 22, 2023•
edited
Loading

No worries, we only decided yesterday. Also, this PR was very useful as an example of what to do.

QuLogic

QuLogic reviewed

View reviewed changes

lib/matplotlib/widgets.pyShow resolvedHide resolved

lib/matplotlib/widgets.pyShow resolvedHide resolved

lib/matplotlib/widgets.pyShow resolvedHide resolved

@oscargus

Remove deprecations and make arguments keyword only

705568a

@oscargus

oscargus force-pushed thewidgetdeprecationremovals branch frome19633f to705568aCompare

September 22, 2023 07:06

QuLogic

QuLogic approved these changes

View reviewed changes

lib/matplotlib/widgets.py

Comment on lines +1665 to +1666

		if (i in inds["ind"]
		or t.get_window_extent().contains(event.x, event.y)):

Copy link

Member

QuLogicSep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fits in a line now:

Suggested change

	if (iininds["ind"]
	ort.get_window_extent().contains(event.x,event.y)):
	ifiininds["ind"]ort.get_window_extent().contains(event.x,event.y):

Copy link

Contributor

anntzerSep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have a further PR that rewrites this loop, so let's just get this in for now.

anntzer

anntzer approved these changes

View reviewed changes

@anntzer

anntzer merged commit37f26da intomatplotlib:main

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

API: changes topic: widgets/UI

3 participants

@oscargus

@QuLogic

@anntzer

[8]ページ先頭

©2009-2025 Movatter.jp