Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Bump setuptools required version because of setuptools_scm v8#26849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hopefully this resolves the azure test failures |
Technically could work with older setuptools and setuptools_scm==7, but encoding that matrix of dependencies is not something I think is worth worrying about, and setuptools 64 is over a year old (though not by a _whole_ lot).
This should probably fall underhttps://matplotlib.org/stable/devel/min_dep_policy.html#test-and-documentation-dependencies "test and documentation" rules and setuptools 64 was release August 2022 so we are good. I have some concern that we are going to make problems for people who want to build "old" numpy (prior to them adopting meson) and us in the same environment as we are pinning to setuptools >=64 and numpy used to pin to setuptools <60. However, hopefully we will land our move to meson soon and this will be moot so merging. |
Leaning to backport because we will have to unbreak it for any bug-fix releases even though we are probably not going to backport the meson work. |
…e of setuptools_scm v8
…849-on-v3.8.xBackport PR#26849 on branch v3.8.x (Bump setuptools required version because of setuptools_scm v8)
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Technically could work with older setuptools and setuptools_scm==7,
but encoding that matrix of dependencies is not something I think is worth worrying about,
and setuptools 64 is over a year old (though not by awhole lot).
setuptools_scm has a version constraint that they do not themselves enforce on the environment
so I've added it to our own requirements, when setuptools_scm is required.
Setuptools_scm's docs are inconsistent in what version theyactually require, so I went with
the one that was most up to date and was in their user facing docs.
(My next choice would be 61, as that is what the runtime warning actually checks)
The config in pyproject.toml was taken from#26621
Closes#26846
PR checklist