Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bump setuptools required version because of setuptools_scm v8#26849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromksunden:setuptools_scm_8
Sep 21, 2023

Conversation

ksunden
Copy link
Member

@ksundenksunden commentedSep 20, 2023
edited
Loading

PR summary

Technically could work with older setuptools and setuptools_scm==7,
but encoding that matrix of dependencies is not something I think is worth worrying about,
and setuptools 64 is over a year old (though not by awhole lot).

setuptools_scm has a version constraint that they do not themselves enforce on the environment
so I've added it to our own requirements, when setuptools_scm is required.

Setuptools_scm's docs are inconsistent in what version theyactually require, so I went with
the one that was most up to date and was in their user facing docs.
(My next choice would be 61, as that is what the runtime warning actually checks)

The config in pyproject.toml was taken from#26621

Closes#26846

PR checklist

@ksunden
Copy link
MemberAuthor

Hopefully this resolves the azure test failures

Technically could work with older setuptools and setuptools_scm==7, but encoding that matrix of dependencies is not something I think is worth worrying about, and setuptools 64 is over a year old (though not by a _whole_ lot).
@tacaswell
Copy link
Member

This should probably fall underhttps://matplotlib.org/stable/devel/min_dep_policy.html#test-and-documentation-dependencies "test and documentation" rules and setuptools 64 was release August 2022 so we are good.

I have some concern that we are going to make problems for people who want to build "old" numpy (prior to them adopting meson) and us in the same environment as we are pinning to setuptools >=64 and numpy used to pin to setuptools <60. However, hopefully we will land our move to meson soon and this will be moot so merging.

@tacaswelltacaswell added this to thev3.8.1 milestoneSep 21, 2023
@tacaswelltacaswell merged commita36e6e2 intomatplotlib:mainSep 21, 2023
@tacaswell
Copy link
Member

Leaning to backport because we will have to unbreak it for any bug-fix releases even though we are probably not going to backport the meson work.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 21, 2023
@tacaswelltacaswell mentioned this pull requestSep 21, 2023
1 task
efiring added a commit that referenced this pull requestOct 4, 2023
…849-on-v3.8.xBackport PR#26849 on branch v3.8.x (Bump setuptools required version because of setuptools_scm v8)
@ksundenksunden mentioned this pull requestNov 2, 2023
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.8.1
Development

Successfully merging this pull request may close these issues.

[MNT]: setuptools-scm v8.0.1 compatibility
3 participants
@ksunden@tacaswell@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp