Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Add overload for slice to Spines.__getitem__#26811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
tacaswell approved these changesSep 18, 2023
are we backporting annotation fixes? |
I'd say backport this one, and most "bug" oriented ones, I don't see a need to backport private API annotations (e.g.#26742) |
QuLogic approved these changesSep 18, 2023
The doc build failures will be fixed by#26818, merging over them. |
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 18, 2023
QuLogic added a commit that referenced this pull requestSep 19, 2023
…811-on-v3.8.xBackport PR#26811 on branch v3.8.x (Add overload for slice to Spines.__getitem__)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Closes#26808
Wouldmaybe prefer being able to tell mypy thatonly the
:slice is allowed, but that is value dependent, not type dependent, so not the right tool for the job.PR checklist