Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bump minimum NumPy version to 1.23#26800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromoscargus:numpy122bump
Feb 9, 2024

Conversation

oscargus
Copy link
Member

PR summary

I take it that we will stick with 1.22 for MPL 3.9. Probably we could have gone to 1.23, but I recall that we are a bit conservative here:https://numpy.org/neps/nep-0029-deprecation_policy.html

PR checklist

@oscargusoscargus added Maintenance PR: dependenciesPull requests that update a dependency file labelsSep 17, 2023
@oscargusoscargus added this to thev3.9.0 milestoneSep 17, 2023
@oscargusoscargus added the CI: Run cygwinRun cygwin tests on a PR labelSep 17, 2023
@oscargusoscargusforce-pushed thenumpy122bump branch 5 times, most recently fromffc43e7 to5366eabCompareSeptember 17, 2023 13:17
@oscargus
Copy link
MemberAuthor

Seems like it is not trivial to install numpy 1.26 (probably because of Meson) on CygWin (hence, the pinning in the install step). However, since build isolation is used, it will try to reinstall an unpinned version.

The minver test is probably related, although I cannot really find anything specific in the 1.22 release notes that seems related. The PR that introduced the failing test is:#26253

@oscargusoscargus mentioned this pull requestSep 18, 2023
4 tasks
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull requestSep 27, 2023
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull requestSep 27, 2023
Cherry-picked out ofmatplotlib#26800; also unpin setuptools.
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull requestOct 3, 2023
Cherry-picked out ofmatplotlib#26800; also unpin setuptools.
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull requestOct 3, 2023
Cherry-picked out ofmatplotlib#26800; also unpin setuptools.
issamarabi pushed a commit to issamarabi/matplotlib that referenced this pull requestOct 5, 2023
Cherry-picked out ofmatplotlib#26800; also unpin setuptools.
Vashesh08 pushed a commit to Vashesh08/matplotlib that referenced this pull requestOct 6, 2023
Cherry-picked out ofmatplotlib#26800; also unpin setuptools.
@oscargus
Copy link
MemberAuthor

oscargus commentedOct 15, 2023
edited
Loading

Seems like there are two floating-point related errors with 1.22. Since these are really small, should I just add a bit of tolerance (and a note that these are for NumPy 1..2)?

An option is, I guess, to try 1.22.1 etc to see if this is a regression that was fixed. (Have checked the change log briefly, but not really sure what the underlying problem is anyway...)

@QuLogic
Copy link
Member

I've had to bump tolerance on at least one of those failing tests in Fedorafedora-python@d429c3d (though I cheated a little bit and put it in the non-x86 commit). I think it's likely to be the SIMD optimization issue that we've run into with newer NumPy.

@github-actionsgithub-actionsbot added Documentation: devdocsfiles in doc/devel Documentation: user guidefiles in galleries/users_explain or doc/users and removed CI: Run cygwinRun cygwin tests on a PR status: needs rebase labelsFeb 9, 2024
@QuLogic
Copy link
Member

We discussed on the call today and decided to go directly to 1.23, so I've pushed that, and also updated the missedpyproject.toml.

@QuLogicQuLogic changed the titleBump minimum NumPy version to 1.22Bump minimum NumPy version to 1.23Feb 9, 2024
@ksundenksunden merged commitd2cc4d0 intomatplotlib:mainFeb 9, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Labels
Documentation: devdocsfiles in doc/develDocumentation: user guidefiles in galleries/users_explain or doc/usersMaintenancePR: dependenciesPull requests that update a dependency file
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

4 participants
@oscargus@QuLogic@tacaswell@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp