Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: Numpy 2.0 removals from ndarray class#26762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xrefnumpy/numpy#24682Only a handful of lines, and _mostly_ in tests/relatively unused utility functions like rgb_to_hsv, but still something that should be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure if it matters too much, but the upstream PR does do theview beforebyteswap.
I'm pretty sure those are equivalent; byteswap will incur a copy (unless inplace=True) and view is just a view, but whether the copy comes before or after the view doesn't really matter. |
PR summary
xrefnumpy/numpy#24682
Only a handful of lines, andmostly in tests/relatively unused utility functions like
rgb_to_hsv, but still something that should be addressed.PR checklist