Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make variables private in Tk-backend#26741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
oscargus wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromoscargus:tkrename

Conversation

oscargus
Copy link
Member

As discussed in#26720 there was an idea to make the common parts of the tk-backend public so that it is included in the documentation. As part of that,@anntzer pointed out#26720 (comment) that we probably should make "global" variables private. This PR does that.

PR summary

PR checklist

@ksundenksunden added this to thev3.9.0 milestoneSep 12, 2023
Copy link
Member

@QuLogicQuLogic left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't understand the motivation, as this is in_backend_tk which is already private? Edit: Rather, I don't understand the motivation of doing it separately from making the module itself public.

@oscargus
Copy link
MemberAuthor

Edit: Rather, I don't understand the motivation of doing it separately from making the module itself public.

I was bored and needed something simple to do...

But I can of course go all the way.

@oscargusoscargus marked this pull request as draftSeptember 17, 2023 13:03
@QuLogicQuLogic modified the milestones:v3.9.0,future releasesApr 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic requested changes

@ksundenksundenksunden approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Projects
None yet
Milestone
future releases
Development

Successfully merging this pull request may close these issues.

3 participants
@oscargus@QuLogic@ksunden
[8]ページ先頭
©2009-2025 Movatter.jp