NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Pin NumPy below v2 for 3.7.x#26706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

timhoffm merged 1 commit intomatplotlib:v3.7.xfromQuLogic:pin-numpy

Sep 6, 2023

Merged

Pin NumPy below v2 for 3.7.x#26706

timhoffm merged 1 commit intomatplotlib:v3.7.xfromQuLogic:pin-numpy

Sep 6, 2023

Conversation

Copy link

Member

PR summary

Pre-emptively pinning away from the major API break for the last bugfix release of the 3.7.x series.

PR checklist

[n/a] "closes #0000" is in the body of the PR description tolink the related issue
[n/a] new and changed code istested
[n/a]Plotting related features are demonstrated in anexample
[n/a]New Features andAPI Changes are noted with adirective and release note
[n/a] Documentation complies withgeneral anddocstring guidelines

Pin NumPy below v2 for 3.7.x

67b15ab

QuLogic added the PR: dependenciesPull requests that update a dependency file label

Sep 6, 2023

QuLogic added this to thev3.7.3 milestone

Sep 6, 2023

oscargus approved these changes

Sep 6, 2023

View reviewed changes

timhoffm approved these changes

Sep 6, 2023

View reviewed changes

Copy link

Member

timhoffm commentedSep 6, 2023

Failed test is a subprocess timeout and unrelated to numpy pinning.

Note that this is not a full protection against getting broken environments because earlier matplotlib versions are unpinnend, and the solver may choose to downgrade to matplotlib 3.7.2 to be able to use numpy=2. Anyway, pinning now is better than not doing anything.