Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Doc] Small fixes found by velin#26705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromoscargus:velindoc
Sep 12, 2023
Merged

Conversation

oscargus
Copy link
Member

@oscargusoscargus commentedSep 6, 2023•
edited
Loading

PR summary

PR checklist

image to.
hsv_max_sat : number, default: 0
The maximum saturation value that the *intensity* map can shift the output
image to.
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I do not know enough about HSV saturation, but it seems a bit "weird" that the min value is larger than the max value...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It does seem odd, but theblend_hsv function docstring below says:

The default extremes arechose so that completely shaded points are nearly black (s = 1, v = 0)and completely illuminated points are nearly white (s = 0, v = 1).

So, I think this is expected although unintuitive at first glance.

image to.
hsv_max_sat : number, default: 0
The maximum saturation value that the *intensity* map can shift the output
image to.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It does seem odd, but theblend_hsv function docstring below says:

The default extremes arechose so that completely shaded points are nearly black (s = 1, v = 0)and completely illuminated points are nearly white (s = 0, v = 1).

So, I think this is expected although unintuitive at first glance.

@ksundenksunden added this to thev3.8.0 milestoneSep 12, 2023
@ksundenksunden merged commit8c94cd2 intomatplotlib:mainSep 12, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 12, 2023
@oscargusoscargus deleted the velindoc branchSeptember 12, 2023 19:05
oscargus added a commit that referenced this pull requestSep 12, 2023
…705-on-v3.8.xBackport PR#26705 on branch v3.8.x ([Doc] Small fixes found by velin)
@ksundenksunden mentioned this pull requestSep 15, 2023
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

@greglucasgreglucasgreglucas approved these changes

Assignees
No one assigned
Labels
Documentation: APIfiles in lib/ and doc/api
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

4 participants
@oscargus@ksunden@timhoffm@greglucas
[8]ページ先頭
©2009-2025 Movatter.jp