Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Check type for set_clip_box#26700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I havesome concerns about the game of whack-a-mole here, we clearly do not do this validation on most of theset_*
methods.
But, adding to all would be a much larger task, and has performance considerations as well. And this one has proven to be problematic, in at least one instance, so not too upset at adding it here.
If it weren't forArtist.set()
and**kwargs
on__init__
expanding toset_*
methods, I'd argue that this job is actually pretty well handled by type checking... But those are two pretty massive holes (as well as, of course, type checking being optional).
Yeah, I was browsing the other setters in |
…700-on-v3.8.xBackport PR#26700 on branch v3.8.x (Check type for set_clip_box)
PR summary
Related to#26522
Check the type before comparison to avoid non-informative errors.
PR checklist