Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Check type for set_clip_box#26700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromoscargus:clipboxtypechecking
Sep 13, 2023

Conversation

oscargus
Copy link
Member

PR summary

Related to#26522

Check the type before comparison to avoid non-informative errors.

PR checklist

Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I havesome concerns about the game of whack-a-mole here, we clearly do not do this validation on most of theset_* methods.

But, adding to all would be a much larger task, and has performance considerations as well. And this one has proven to be problematic, in at least one instance, so not too upset at adding it here.

If it weren't forArtist.set() and**kwargs on__init__ expanding toset_* methods, I'd argue that this job is actually pretty well handled by type checking... But those are two pretty massive holes (as well as, of course, type checking being optional).

@oscargus
Copy link
MemberAuthor

Yeah, I was browsing the other setters inartist, but most seemed quite "obvious". Maybe not much point adding type checking for bools, even though they will probably also fail similarly....

@ksundenksunden added this to thev3.8.0 milestoneSep 11, 2023
@QuLogicQuLogic merged commitec8c739 intomatplotlib:mainSep 13, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 13, 2023
QuLogic added a commit that referenced this pull requestSep 14, 2023
…700-on-v3.8.xBackport PR#26700 on branch v3.8.x (Check type for set_clip_box)
@oscargusoscargus deleted the clipboxtypechecking branchSeptember 14, 2023 05:13
@ksundenksunden mentioned this pull requestSep 15, 2023
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@oscargus@QuLogic@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp