NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Update PR template doc links#26684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

timhoffm merged 1 commit intomatplotlib:mainfromrcomer:pr-template-doc-links

Sep 3, 2023

Merged

Update PR template doc links#26684

timhoffm merged 1 commit intomatplotlib:mainfromrcomer:pr-template-doc-links

Sep 3, 2023

Conversation

Copy link

Member

PR summary

Looks like documentation guidance has been updated more recently than the PR template. The links are currently all getting redirected to the top of the doc guidance page.

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

Update PR template doc links [skip ci]

3d116a7

rcomer added this to thev3.9.0 milestone

Sep 3, 2023

Copy link

Member

jklymak commentedSep 3, 2023

I'd just have one link to the dev guide. This wall of text is probably not read by anyone.

Copy link

MemberAuthor

I think the checklist is useful: I certainly paid attention to it when I opened my first PR here, and I still sometimes need the reminder to add aversionadded directive. I’m not sure I ever really noticed the long comment below the checklist though.