Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
fix set_pickradius and set_picker conflict#26682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join uson gitter for real-time discussion.
For details on testing, writing docs, and our review process, please seethe developer guide
We strive to be a welcoming and open project. Please follow ourCode of Conduct.
However, My instinct is to be in favor of supporting them, as they are supported by the superclass, however, I think that we should also update the docstring (and type hints, for that matter). |
should I update this in this PR? Or maybe start a feature type issue with this? |
I would lean toward it being done together, but yeah, some care to be taken in making it behave as expected (with some weight towards existing behavior, at least for the case of Also consider integer input (e.g. But further beware of We may have to explicitly handle the None/boolean cases here instead. |
actually, when I set a integer value,
but I don't know if it's necessary. What do you think? |
certainly you can pass the otherwise equivalent It is not the case that integers need to be handled differently than floats, other than that bools count as integers. |
hello, I'm having a problem with matplotlib installation in my ve, i think it's a problem with my operational system and I'll have to format my computer, but I'm waiting till the end of semester for it. To get this PR accepted I should change this details you mentioned, right? |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Fix conflict with _pickradius "losing" its value when set_picker was used after set_pickradius for 2D Lines.
Set_picker now setting value as described in documentation (float type for _pickradius)
PR