Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix flaky CI tests#26680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix flaky CI tests#26680
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| assert x == ',$\\mathdefault{,0{,}5},$' | ||
| def test_locale_comma(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you explain this song and dance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, it's in the commit message:
On some systems/pytest versions, the skip in an exception handler does not skip, but is treated as an exception. Namely, the ARM test machine in Cirrus and on my WSL Ubuntu.
I assume that is a bug somewhere in pytest but the subprocess avoids that. Also, changing the locale is a global modification, and it seems safer to do so in a subprocess, and not have to worry about fixing it up in the main process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Perhaps comment the code as well? This seems an odd thing to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done.
On some systems/pytest versions, the skip in an exception handler doesnot skip, but is treated as an exception. Namely, the ARM test machinein Cirrus and on my WSL Ubuntu.
The main parent process is using Agg, so the subprocess should as well,to be able to unpickle correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Feel free to self merge in case you want to squash
…680-on-v3.8.xBackport PR#26680 on branch v3.8.x (Fix flaky CI tests)
PR summary
I've pulled these out of#24597 as that is taking some time to be merged, and it seems like these are failing more often now. Some of these were also triggered on#26621 (while it had bugs) as well.
PR checklist