Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

setupext: support using environment variables for dependencies#26679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
mathstuf wants to merge1 commit intomatplotlib:mainfrommathstuf:deps-by-env

Conversation

@mathstuf
Copy link

PR summary

On Windows, without Conda or the libraries being in default locations, matplotlib has problems finding freetype and qhull. Add ultimate fallback solutions using very specific environment variables named{FREETYPE,QHULL}_{INCLUDE,LIBRARY}_DIRS.

My attempts at usingCL andLINK were failing; not sure if the migration tomeson made these obsolete or not.

PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@mathstuf
Copy link
Author

FWIW, before I go and write docs for this, I'd like to know that it's a suitable solution to the problem. If needed, theQHULL_* variables can be additionally guarded behind a Windows check.

@melissawm
Copy link
Member

Looks like there are some related failures in CI -@mathstuf would you take a look? Let us know if you need help. Thanks!

On Windows, without Conda or the libraries being in default locations,matplotlib has problems finding freetype and qhull. Add ultimatefallback solutions using very specific environment variables named`{FREETYPE,QHULL}_{INCLUDE,LIBRARY}_DIRS`.
@mathstuf
Copy link
Author

Whoops, indeed. I had typos and copy pasta that I had fixed in testing but had inconsistently applied back to my development machine. Applied here too now.

@ksunden
Copy link
Member

I'll ping in@QuLogic here... We are in the process of moving the build system to meson (see#26621)

That PR gets rid of thesetupext.py file entirely, rather relying on meson build files.

@mathstuf
Copy link
Author

That would be suitable to me ifmeson can reliably find these dependencies on Windows then. It seems for.pc to be reliable I have to go chase downif (NOT WIN32) guarding conditions on the.pc file generation/installation in some projects (libpng for example).

@mathstuf
Copy link
Author

Seems to be obsolete since#26621 removedsetupext.py.

@QuLogic
Copy link
Member

That would be suitable to me ifmeson can reliably find these dependencies on Windows then. It seems for.pc to be reliable I have to go chase downif (NOT WIN32) guarding conditions on the.pc file generation/installation in some projects (libpng for example).

It should be; we don't have any platform-specific checks for dependencies, just the standarddependency or fallback tofind_library. Please open a new bug if that remains an issue.

@mathstuf
Copy link
Author

Will know the next time we go and bump packages. Thanks :) .

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicAwaiting requested review from QuLogic

Assignees

No one assigned

Projects

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mathstuf@melissawm@ksunden@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp