Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[DOC] Slightly improve the LineCollection docstring#26676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| or the equivalent numpy array with two columns. Each line | ||
| or the equivalentMx2numpy array with two columns. Each line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(M, 2)
I would perhaps completely drop the "list of points" and just write
A sequence ``[line0, line1, ...]`` where each line is a (N, 2)-shapearray-like of points:: line0 = [(x0, y0), (x1, y1), ...]Each line can...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't really care. This is a very quick PR to improve a misunderstanding in#26676. I have no time to bike shed this further. Feel free to push to this PR or take over if you think it's possible/worth improving further.
We can always write a 3D docstring, can't we? |
Yes. And thinking again, maybe that'd be the sane thing to do, even though that means writing an empty Anybody, this PR is just a quick fix for a misleading wording in LineCollection. I'm not going to bike shed this furher or add the 3D docstring. IMHO this can go in as-is as an improvement. Please take over for further improvements. |
…676-on-v3.8.xBackport PR#26676 on branch v3.8.x ([DOC] Slightly improve the LineCollection docstring)
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Closes#26674. There's two aspects to the issue:
the
LineCollectiondescription is slightly unclear. - This is fixed here.Line3DCollectioninherits__init__and reuses its docstring. That's problematic because the the description is 2D. I don't see a good solution here. We likely don't want to replicate the whole docstring, and also a comment like "This holds analogously for 3D with points (x0, y0, z0) and Mx3 arrays." is awkward both for the 2D and 3D docstrings.I therefore propose to leave it at this. If the 2D description is clear, the extension to 3D can be inferred by the user. - Not ideal, but the least bad option IMHO.