Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Clarify loading of backend FigureCanvas and show().#26665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lib/matplotlib/pyplot.py Outdated
| if not manager_pyplot_show: | ||
| raise ValueError( | ||
| "Backend `newbackend` defines neither `FigureCanvas.manager_class` nor " | ||
| "a toplevel `show` function") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe I am missing something obvious (or do not see properly), but do we use backticks in error messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Removed them.
2dc4ae2 to48e9e65CompareUh oh!
There was an error while loading.Please reload this page.
- FigureCanvas is now required to exist on backend modules (since the deprecation elapsed in 3.8) and we indeed already access that attribute directly when checking required_interactive_framework, so remove redundant getattrs.- Clarify the error message when manager_class is None *and* there's no global show(). (Previously an AttributeError would be raised.)
…665-on-v3.8.xBackport PR#26665 on branch v3.8.x (Clarify loading of backend FigureCanvas and show().)
PR summary
PR checklist