Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: Fix some small issues#26657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 4 commits intomatplotlib:mainfromQuLogic:fix-doc-bugs
Aug 31, 2023
Merged

Conversation

QuLogic
Copy link
Member

PR summary

PR checklist

@QuLogicQuLogic added this to thev3.8.0 milestoneAug 31, 2023
Comment on lines 31 to 34
@lines.Line2D.axes.setter
def axes(self, new_axes):
self.text.axes = new_axes
lines.Line2D.axes.fset(self, new_axes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is an unusual enough pattern, that it probably warrants a comment explaining it. (Just a simple# Override the axes property setter and potentially# Call the superclass property setter)

Itworks, and is probably about the best you can do to override the property setter/call the super-class version of the property setter.

Some things I thought about which would have made some sense to me, but don't seem to work in this context:

  • using@MyLine.axes.setter (MyLine is not available at class instantiation time)
    • I worried a bit about the setter accidentally overriding the parent classes setter, but that doesnot happen)
  • usingsuper().axes.fset(new_axes) (super().axes resoves to the return of the getter, not the property descriptor)

@ksunden
Copy link
Member

Other than adding a comment explaining the unusual property setter override, LGTM

@ksundenksunden merged commit14a0c5b intomatplotlib:mainAug 31, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 31, 2023
@QuLogicQuLogic deleted the fix-doc-bugs branchAugust 31, 2023 19:03
ksunden added a commit that referenced this pull requestAug 31, 2023
…657-on-v3.8.xBackport PR#26657 on branch v3.8.x (DOC: Fix some small issues)
@ksundenksunden mentioned this pull requestSep 15, 2023
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@ksunden@oscargus

[8]ページ先頭

©2009-2025 Movatter.jp