Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: array labelcolor for Tick#26598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| def test_tick_labelcolor_array(): | ||
| # Smoke test that we can instantiate a Tick with labelcolor as array. | ||
| ax = plt.axes() | ||
| XTick(ax, 0, labelcolor=np.array([1, 0, 0, 1])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is there a test somewhere that this actually works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I’m sorry I don’t understand the question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, you've got this setup as a smoke test so I was wondering if somewhere in the code there's a test that passing an array to xtick color colors the tick the color of the array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One can add that check viatick.label1.get_color() (and also forlabel2; and if you want to be even more precise check thattick1line,tick2line andgridline do not get that color).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, I did intend to respond to this but have not been well for a few days. It looks like I’m too late now but there is this test that sets a labelcolor with a string and then checks it via the getter:
https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/tests/test_axes.py#L6778-L6788
Is that enough or is there a concern that using an array could break things further along the process than the instantiation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Latter but also it's not a blocker and we can always add later if there's a bug that shows we should have added it ;)
Hope you're feeling better!
…598-on-v3.7.xBackport PR#26598 on branch v3.7.x (FIX: array labelcolor for Tick)
…598-on-v3.8.xBackport PR#26598 on branch v3.8.x (FIX: array labelcolor for Tick)
PR summary
Fixes#26588 following@anntzer's suggestion at#26588 (comment). The example code from#26588 (comment) now produces
Is there a better place to put the test? I wasn't expecting to create a new module...
PR checklist