Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Squeeze post-converted values when validating limits#26597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| # Numpy 1.25 deprecated casting [2.] to float, catch_warnings added to error on main | ||
| # can be removed once the minimum numpy version has expired the warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"to error on main" should be "to avoid error on main"? I'm pretty sure this test doesn't error...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I meant to error on main prior to this patch being applied
| with warnings.catch_warnings(): | ||
| f, ax = plt.subplots() | ||
| ax.plot(["a", "b", "c", "d"], [1, 2, 3, 4]) | ||
| ax.set_xlim("b", "c") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| withwarnings.catch_warnings(): | |
| f,ax=plt.subplots() | |
| ax.plot(["a","b","c","d"], [1,2,3,4]) | |
| ax.set_xlim("b","c") | |
| f,ax=plt.subplots() | |
| ax.plot(["a","b","c","d"], [1,2,3,4]) | |
| withwarnings.catch_warnings(): | |
| ax.set_xlim("b","c") |
Uh oh!
There was an error while loading.Please reload this page.
| # Numpy 1.25 deprecated casting [2.] to float, catch_warnings added to error on main | ||
| # can be removed once the minimum numpy version has expired the warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I meant to error on main prior to this patch being applied
| # Numpy 1.25 deprecated casting [2.] to float, catch_warnings added to error on main | ||
| # can be removed once the minimum numpy version has expired the warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| # Numpy 1.25 deprecated casting [2.] to float, catch_warnings added to error on main | |
| # can be removed once the minimum numpy version has expired the warning | |
| # Numpy 1.25 deprecated casting [2.] to float, catch_warnings added to error | |
| # without patch | |
| # can be removed once the minimum numpy version has expired the warning |
Closesmatplotlib#26596Ensures that ndarrays can be passed to later on. In this particular case, we know that we expect a single value.
…597-on-v3.7.xBackport PR#26597 on branch v3.7.x (Squeeze post-converted values when validating limits)
…597-on-v3.8.xBackport PR#26597 on branch v3.8.x (Squeeze post-converted values when validating limits)
PR summary
Closes#26596
Ensures that ndarrays can be passed to later on. In this particular case, we know that we expect a single value.
PR checklist