Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
MNT: Enable wheels for Python 3.12#26582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
699182c toc7d91b0Compareeffigies commentedAug 23, 2023
FWIW, I have had some successusing the [build-system]requires = ["setuptools","setuptools_scm[toml]>=6.2","cython",# Newer than NEP29-minimum: compile against oldest numpy available"numpy==1.26b1; python_version >= '3.12rc1'","numpy==1.24; python_version >= '3.11' and python_version < '3.12.dev0'",# NEP29-minimum as of Aug 17, 2023"numpy==1.22; python_version >= '3.8' and python_version < '3.11'",]build-backend ="setuptools.build_meta" |
f6cf7ad toc7b62daCompare
Yes, I did see that elsewhere, though I was hoping to avoid it since it's mostly a wheel-building issue.
Note though that sinceNumPy 1.25, we no longer use NEP29 as the basis for thebuild requirement. |
effigies commentedAug 23, 2023
I just saw that (via#26443), and look forward to removing the extra lines from my projects. |
Ah, no wheels for contourpy; I really don't want to have to figure out how to get full Meson support in there too; so waiting oncontourpy/contourpy#262 |
| CIBW_ARCHS: ${{ matrix.cibw_archs }} | ||
| # Remove this once NumPy with Python 3.12 wheels is not pre-release. | ||
| CIBW_BEFORE_BUILD: >- | ||
| pip install certifi "pybind11>=2.6" "setuptools>=42" "setuptools_scm>=7" && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would you be willing to try adding contourpy'sbuild-requires? They're not likely to put out a wheel until numpy puts out a final 1.26.0 release, which is not going to happen until 3.12 final.
| pip install certifi "pybind11>=2.6" "setuptools>=42" "setuptools_scm>=7" && | |
| pip install certifi "setuptools>=42" "setuptools_scm>=7" "meson >= 1.2.0" "meson-python >= 0.13.1" "pybind11 >= 2.10.4" |
neutrinocerosAug 26, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Where are you getting this from ? CPython 3.12.0 is scheduled for early October while numpy 1.26 's milestone is currently aimed at September 1st.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Possibly a faulty memory. Apologies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no problem, just asking :)
8899da7 to17ed86bCompareOwee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free tosuggest an improvement. |
…582-on-v3.8.xBackport PR#26582 on branch v3.8.x (MNT: Enable wheels for Python 3.12)
The backport was included in#26672 |
PR summary
We should probably figure out tests#24711, but that shouldn't stop us from making the wheels at least.
Fixes#26557
PR checklist