Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Use sys.platform over os.name#26576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mypy does not recognize the latter [1], and there is a typing failure onWindows because of `os.geteuid`.[1]python/mypy#13002
Hmm, am I missing something, or did Cygwin not actually run? I definitely wanted to check that. |
Hmmm... the workflowlooks like it should work and it appears to have worked recently on#26543 so not sure what is going on there... I'll close/open to cycle and see if it gets picked up... could be that the there is a narrow path where it doesn't quite get the right conditions... (which we should maybe try and figure out, but I'm at a bit of a loss) |
ksunden commentedAug 23, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
matplotlib/.github/workflows/cygwin.yml Lines 25 to 27 ina4dca24
I think it is failing to be triggered because no files in src (or the cygwin workflow file) were touched... We may wish to reconsider that restriction, at least for the "run because I labeled it" case, (though that may be hard to separate out) For now, I think you should be able to run it as a manually triggered run on your fork (I have the option on my fork, but can't trigger it on yours) |
OK, looks like it passed on my fork:https://github.com/QuLogic/matplotlib/actions/runs/5955561881/job/16154461275 |
…576-on-v3.8.xBackport PR#26576 on branch v3.8.x (Use sys.platform over os.name)
PR summary
mypy does not recognize the latter [1], and there is a typing failure on Windows because of
os.geteuid.[1]python/mypy#13002
PR checklist