Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[DOC]: codespace link in contribute index#26573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ..:octicon:`codespaces;1em;sd-text-info`placeholder for codespaces link | ||
| :octicon:`codespaces;1em;sd-text-info`:ref:`How do I start a pull request? <how-to-contribute>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not attached to the focus on a PR given I used the pr icon in the last bullet, just can't think of anything else right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry I had misread - this looks good to me, we don't want it to be too long either. Maybe "How do I start a pull request on the browser?" if it fits...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So the link goes to the local + codespace contribute instructions, which I think is fine b/c some contributors won't have the bandwidth to use codespaces. I think what I'm struggling w/ is differentiating that this is the nuts and bolts writing portion of the process rather than the exploratory find something to work on stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That sounds good then, thanks!
…573-on-v3.8.xBackport PR#26573 on branch v3.8.x ([DOC]: codespace link in contribute index)
Uh oh!
There was an error while loading.Please reload this page.
Following on from#26201, this adds a bullet link on the contribute landing page out to the set up part of the contributing guide. Also cleans up the styling in the new contributor section cause it feels really busy on mobile.
attn:@melissawm