Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[doc]: added section Verify installation#26565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
doc/devel/development_setup.rst Outdated
| Verify the Installation | ||
| ======================= | ||
| 1. Run the following command to make sure you have correctly installed matplotlib in editable mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| 1.Run the following command to make sure you have correctly installedmatplotlib in editable mode. | |
| Run the following command to make sure you have correctly installedMatplotlib in editable mode. |
our style guide has Matplotlib always capitalized
doc/devel/development_setup.rst Outdated
| This command should return : ``<matplotlib_local_repo>\lib\matplotlib\__init__.py`` | ||
| 2. We encourage you to run tests and build docs to verify that the code installed correctly and that the docs build are clean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| 2.We encourage you to run tests and build docs to verify that the code installed correctly and that the docs buildare clean, | |
| We encourage you to run tests and build docs to verify that the code installed correctly and that the docs buildcleanly, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok the suggested changes are done, can you help to re-review it, thanks.
Does this supersede#26416? |
91ca64c to6f6241aCompareI'm not sure where the white space is - I suggest rerunning the hook locally and then staging and commiting the file after the hook runs. |
doc/devel/development_setup.rst Outdated
| Run the following command to make sure you have correctly installed Matplotlib in editable mode. | ||
| The command should be run when the virtual environment is activated :: | ||
| python -c "import matplotlib; print(matplotlib.__file__)" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Run the following command to make sure you have correctly installed Matplotlib in editable mode. | |
| The command should be run when the virtual environment is activated :: | |
| python -c "import matplotlib; print(matplotlib.__file__)" | |
| Run the following command to make sure you have correctly installed Matplotlib in editable mode. | |
| The command should be run when the virtual environment is activated :: | |
| python -c "import matplotlib; print(matplotlib.__file__)" | |
Hint: selecting text on github makes it easy to find where the trailing whitespace is
Um@devilsaint99 let us know if you'd like to do the rebase or have us do it? |
[doc]: added section Verify Installation[doc]: added section Verify installation
6f6241a tod03fce0CompareCongrats on your first PR to Matplotlib, thank you for all the effort you've put into this, and we hope to see you again🥳 |
…565-on-v3.8.xBackport PR#26565 on branch v3.8.x ([doc]: added section Verify installation)
PR summary
PR checklist