Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix broken "save figure" with GTK4 on mac#26558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
stevezhang1999 wants to merge2 commits intomatplotlib:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This will have to use the new API only if available (GTK 4.10+) and the old API otherwise. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
In short, the current GTK 4 works on Ubuntu 22.04 but fails on Mac. After this patch, GTK 4 only works on the latest Ubuntu (23.04) but issues on Mac are fixed. Want to know how we want to proceed - keeping the broken app on Mac or moving to Ubuntu 23.04.
This PR tries to fix GTK4 GUI on Mac by using newer version of GTK4 APIs -
FileDialoginstead ofFileChooserNativewhich is deprecated. The fixed version works well on Mac. Unfortunately, it doesn't work on my Ubuntu 22.04. I got response from the Genome team that this newer version of GTK4 is not supported on Ubuntu 22.04, however, it's available on Ubuntu 23.04.PR checklist