Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add ninja to Cygwin builder#26543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 2 commits intomatplotlib:mainfromQuLogic:fix-cygwin
Aug 21, 2023
Merged

Conversation

QuLogic
Copy link
Member

PR summary

Since there are no contourpy wheels, it must be built from source, and pre-packaged ninja is better than trying to build from sdist. This was always done, but broke when contourpy switched to Meson.

PR checklist

Since there are no contourpy wheels, it must be built from source, andpre-packaged ninja is better than trying to build from sdist.
@QuLogicQuLogic added the CI: Run cygwinRun cygwin tests on a PR labelAug 18, 2023
@QuLogicQuLogic added this to thev3.8.0 milestoneAug 18, 2023
@QuLogic
Copy link
MemberAuthor

I think this failed because we need acontourpy release withcontourpy/contourpy#260 included so that it doesn't try to pull inninja from PyPI, and uses our existing Cygwin copy.

@ianthomas23
Copy link
Member

Maybe the best workaround until the next contourpy release is to explicitly build it without build isolation, something like (unchecked):

python -m pip install meson-python pybind11python -m pip install --no-build-isolation contourpy

@QuLogic
Copy link
MemberAuthor

It looks like that has worked after a couple tries.

Copy link
Member

@ianthomas23ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@ksundenksunden merged commitdb533bf intomatplotlib:mainAug 21, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 21, 2023
@QuLogicQuLogic deleted the fix-cygwin branchAugust 21, 2023 17:20
ksunden added a commit that referenced this pull requestAug 21, 2023
…543-on-v3.8.xBackport PR#26543 on branch v3.8.x (Add ninja to Cygwin builder)
@ksundenksunden mentioned this pull requestAug 23, 2023
1 task
@ksundenksunden mentioned this pull requestSep 15, 2023
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ianthomas23ianthomas23ianthomas23 approved these changes

Assignees
No one assigned
Labels
CI: Run cygwinRun cygwin tests on a PR
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@ianthomas23@ksunden
[8]ページ先頭
©2009-2025 Movatter.jp