Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

TYP: Add overloads for FT2Font.get_sfnt_table#26540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
oscargus merged 2 commits intomatplotlib:mainfromQuLogic:sfnt-typing
Aug 30, 2023

Conversation

QuLogic
Copy link
Member

PR summary

This may be perhaps a bit overboard, but I don't expect these dictionaries to change structure very often.

Also, fix type ofGlyph.bbox, which is a property, not a method.

PR checklist

@QuLogicQuLogic added this to thev3.8.0 milestoneAug 17, 2023
@ksunden
Copy link
Member

Stubtest does not like that the typeddicts are "public", as it sees them and not included at runtime.

Youmay be able to fix this with__all__, though you would probably have to include that in the C extension as well, so may not be worth it.

Prefixing the class names with_ silences the warnings.

Alternatively, you could define the Typed Dicts in a private module and import them.

@QuLogic
Copy link
MemberAuthor

Making them private seems the simplest, and still seems to work for mathtext.

@oscargusoscargus merged commit7dcc416 intomatplotlib:mainAug 30, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 30, 2023
@QuLogicQuLogic deleted the sfnt-typing branchAugust 30, 2023 07:21
oscargus added a commit that referenced this pull requestAug 30, 2023
…540-on-v3.8.xBackport PR#26540 on branch v3.8.x (TYP: Add overloads for FT2Font.get_sfnt_table)
@ksundenksunden mentioned this pull requestSep 15, 2023
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@ksunden@oscargus

[8]ページ先頭

©2009-2025 Movatter.jp