Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix input check in Poly3DCollection.__init__#26532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

stevezhang1999
Copy link
Contributor

PR summary

PR checklist

So far higher level APIs likeplot_surface andplot_trisurf ensure the input for callingPoly3DCollection is valid so usually we won't trigger the bug.
By inspecting test code coverage report, this part of code has never been tested. A test is added to ensure it works.

code for generating coverage report specifying folder - for people who may be curious

 python -m pytest .\lib\mpl_toolkits\mplot3d\tests\test_axes3d.py .\lib\mpl_toolkits\mplot3d\tests\test_legend3d.py --cov=./lib/mpl_toolkits/mplot3d --cov-report=html:coverage_re

@ksundenksunden added this to thev3.7.3 milestoneAug 15, 2023
@oscargusoscargus merged commit267b7c0 intomatplotlib:mainAug 16, 2023
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 267b7c08bf39ea2d40ff348e6d7eddf218e94c74
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #26532: Fix input check in Poly3DCollection.__init__'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-26532-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR#26532 on branch v3.7.x (Fix input check in Poly3DCollection.init)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 16, 2023
oscargus added a commit that referenced this pull requestAug 16, 2023
…532-on-v3.8.xBackport PR#26532 on branch v3.8.x (Fix input check in Poly3DCollection.__init__)
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull requestAug 18, 2023
oscargus added a commit that referenced this pull requestAug 18, 2023
…3.7.xBackport PR#26532: Fix input check in Poly3DCollection.__init__
@ksundenksunden mentioned this pull requestSep 15, 2023
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7.3
Development

Successfully merging this pull request may close these issues.

Typo in Poly3DCollection constructor
4 participants
@stevezhang1999@ksunden@QuLogic@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp