Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Replaced list with tuple in pyplot for axes#26521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 2 commits intomatplotlib:mainfromEngineerKhan:EngineerKhan-patch-2
Aug 30, 2023

Conversation

EngineerKhan
Copy link
Contributor

PR summary

PR checklist

ksunden
ksunden previously requested changesAug 14, 2023
@@ -1134,7 +1134,7 @@ def figlegend(*args, **kwargs) -> Legend:

@_docstring.dedent_interpd
def axes(
arg: None | tuple[float, float, float, float] = None,
arg: None | tuple(float, float, float, float) = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These need to be square brackets, that is type hinting syntax, which does not change because it's a tuple

Copy link
Member

@timhoffmtimhoffmAug 30, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I took the liberty of reverting this via an additional commit in the GitHub UI.@devs Please squash-merge.

rcomer and EngineerKhan reacted with thumbs up emoji
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@rcomerrcomer linked an issueAug 14, 2023 that may beclosed by this pull request
@timhoffmtimhoffm marked this pull request as ready for reviewAugust 30, 2023 20:13
@timhoffmtimhoffm dismissedksunden’sstale reviewAugust 30, 2023 20:14

type hint changes are reverted

@timhoffmtimhoffm added this to thev3.8.0 milestoneAug 30, 2023
@timhoffmtimhoffm merged commit80fb37d intomatplotlib:mainAug 30, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 30, 2023
@timhoffm
Copy link
Member

Thanks@EngineerKhan!

ksunden added a commit that referenced this pull requestAug 31, 2023
…521-on-v3.8.xBackport PR#26521 on branch v3.8.x (Replaced list with tuple in pyplot for axes)
@ksundenksunden mentioned this pull requestSep 15, 2023
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@timhoffmtimhoffmtimhoffm approved these changes

@ksundenksundenksunden left review comments

Assignees
No one assigned
Projects
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

[Doc]: Pyplot Axes – tuple or list?
3 participants
@EngineerKhan@timhoffm@ksunden
[8]ページ先頭
©2009-2025 Movatter.jp