Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Clarify interaction between params of get_path_collection_extents.#26514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
That master_transform is ignored is clear looking at the implementationin _path.h (the `if (Ntransforms)` branch drops master_transform;compare with the implementation of point_in_path_collection). One canalso compare```from matplotlib.path import *; from matplotlib.transforms import *get_path_collection_extents( Affine2D().scale(2, 3), [Path([(1, 2), (3, 4)])], [], [(0, 0)], IdentityTransform())get_path_collection_extents( Affine2D().scale(2, 3), [Path([(1, 2), (3, 4)])], [IdentityTransform()], [(0, 0)], IdentityTransform())```
QuLogic approved these changesAug 18, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 18, 2023
…et_path_collection_extents.
ksunden added a commit that referenced this pull requestAug 18, 2023
…514-on-v3.8.xBackport PR#26514 on branch v3.8.x (Clarify interaction between params of get_path_collection_extents.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That master_transform is ignored is clear looking at the implementation in _path.h (the
if (Ntransforms)branch drops master_transform; compare with the implementation of point_in_path_collection). One can also compare(We can discuss whether the behavior makes sense, especially as point_in_path_collection has the opposite behavior; it may be a bug, I'm just documenting the actual behavior.)
PR summary
PR checklist