Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Disableadd_html_cache_busting on Sphinx 7.1+#26493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
story645 merged 1 commit intomatplotlib:mainfromAA-Turner:sphinx-7-1-checksums
Aug 11, 2023

Conversation

AA-Turner
Copy link
Contributor

@AA-TurnerAA-Turner commentedAug 11, 2023•
edited
Loading

PR summary

Hi,

Insphinx-doc/sphinx#11518,@story645 noted that MPL's documentation failed when running with Sphinx 7.1. This PR disables the customadd_html_cache_busting() function withinconf.py when running on Sphinx 7.1 and later, in favour of Sphinx's new native asset checksum support.

Thanks,
Adam

PR checklist

pradyunsg and story645 reacted with heart emoji
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@QuLogicQuLogic added the Documentation: buildbuilding the docs labelAug 11, 2023
@QuLogicQuLogic added this to thev3.7-doc milestoneAug 11, 2023
@story645story645 merged commit48e2891 intomatplotlib:mainAug 11, 2023
@story645
Copy link
Member

Thanks so much for fixing this and extra thanks for doing it so quickly!

AA-Turner reacted with heart emoji

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 48e28914d02dc5d50e3945b29f3d83da645b765f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #26493: Disable ``add_html_cache_busting`` on Sphinx 7.1+'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-26493-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR#26493 on branch v3.7.x (Disableadd_html_cache_busting on Sphinx 7.1+)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@lumberbot-app
Copy link

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@QuLogic
Copy link
Member

@meeseeksdev backport to v3.8.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 18, 2023
ksunden added a commit that referenced this pull requestAug 18, 2023
…493-on-v3.8.xBackport PR#26493 on branch v3.8.x (Disable ``add_html_cache_busting`` on Sphinx 7.1+)
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull requestAug 19, 2023
@QuLogicQuLogic modified the milestones:v3.7-doc,v3.8.0Sep 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

@story645story645story645 approved these changes

Assignees
No one assigned
Labels
Documentation: buildbuilding the docs
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@AA-Turner@story645@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp