Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix Gtk3 crash when running inside of IPython#2646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Sorry for the poor issue reporting on this. I don't know what you think the likely timeline on#2624 is, but would it be possible to hold off on merging this until after that one (just to avoid a re-base where I have to think). |
I think we're likely to have a complicate merge and/or rebase regardless, since this is on v1.3.x... |
Given that this is a 1-line deletion, I don't see a major problem. One way to handle it would be to merge this in 1.3.x, and then just make the equivalent change in the refactor PR. |
Ah, I missed what branch it was against. The problem is that the change is now in a different file which, from re-basing to get rid of the |
Fix Gtk3 crash when running inside of IPython
As reported in#2624, the Gtk3 backends and IPython are not playing well together, and either no window is displayed, or Python exceptions or even segfaults are thrown.
This, along withipython/ipython#4640 seem to make everyone happy.