Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixes for pycodestyle v2.11#26414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
oscargus merged 1 commit intomatplotlib:mainfromrcomer:flake8-fixes
Jul 30, 2023
Merged

Conversation

@rcomer
Copy link
Member

@rcomerrcomer commentedJul 30, 2023•
edited
Loading

PR summary

flake8 is currently failing in CI with

E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`

I think this is the relevant change:PyCQA/pycodestyle#1086

In the bubble example, it looks like the type check was there just to make sure we get an array-like out of the method. We can achieve that with thekeepdims keyword.

Everywhere else I just replaced== withis as that preserves existing behaviour so seems safest. Possibly some places could have usedisinstance instead but I do not know if there is an advantage to changing it to that (and I also do not know those parts of the code well enough to make that call).

PR checklist

@rcomerrcomer added this to thev3.7-doc milestoneJul 30, 2023
@rcomerrcomer mentioned this pull requestJul 30, 2023
6 tasks
@oscargusoscargus modified the milestones:v3.7-doc,v3.7.3Jul 30, 2023
@oscargus
Copy link
Member

Changed the milestone as this is also library code.

@oscargusoscargus merged commitf7a8cab intomatplotlib:mainJul 30, 2023
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 f7a8cabc1cf1ac9b35502f08e764d74d07d865ac
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #26414: Fixes for pycodestyle v2.11'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-26414-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR#26414 on branch v3.7.x (Fixes for pycodestyle v2.11)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@rcomer
Copy link
MemberAuthor

I assumed we would want to backport this to the doc branch as the CI is failing there too -#26413.

@QuLogic
Copy link
Member

We don't backport to that branch because it wouldn't have any effect, but this will, so it's okay to backport.

rcomer reacted with thumbs up emoji

QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull requestAug 1, 2023
@QuLogicQuLogic modified the milestones:v3.7.3,v3.7-docAug 1, 2023
QuLogic added a commit that referenced this pull requestAug 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jklymakjklymakjklymak approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

v3.7-doc

Development

Successfully merging this pull request may close these issues.

4 participants

@rcomer@oscargus@QuLogic@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp