Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add road sign#26360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
PaulLinZ wants to merge1 commit intomatplotlib:mainfromPaulLinZ:add_road
Closed

add road sign#26360

PaulLinZ wants to merge1 commit intomatplotlib:mainfromPaulLinZ:add_road

Conversation

PaulLinZ
Copy link

PR summary

This PR is to address the concerns raised in#24618. I add three file in the add_road_sign. I don't know whether or not they will work because my ability is pool. I just want to make contribution to open-source. Could you give me some advice on how to make right contribution to open-source. I need advise on if this was the correct approach, or if I should try something else.

PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@melissawm
Copy link
Member

melissawm commentedJul 20, 2023
edited
Loading

Hi@PaulLinZ - thanks for the PR!

There are a couple of linting/style failures, can you take a look and fix those while we wait for a maintainer to review the code? You can see that by clicking on "Details" next to the Linting check below, or clicking here:https://github.com/matplotlib/matplotlib/actions/runs/5608270348/job/15193554642?pr=26360

Thanks!

@ksunden
Copy link
Member

Note that I think what was intended by the issue (and@oscargus can correct me if I'm wrong) was to add such arrow box styles to the library code itself.

This PR adds files to a location that is not part of the library, nor is it included in the documentation as an example, and as such will not be merged in its current state.

Additionally, be advised that there are two existing PRs (#24744 and#24697, both by the same person) which are attempting to resolve the same issue (and do so by adding to the library). In general we prefer to merge the earlier PR when possible. (Though, admittedly, those ones have stalled a bit in a draft state, though the original author has within the last ~month indicated they are interested in picking it back up)

@ksunden
Copy link
Member

Closing for lack of response and fundamental issues with the implementation. Please feel free to open a new PR or comment on the other PRs addressing this problem if you have other ideas.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees
No one assigned
Projects
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@PaulLinZ@melissawm@ksunden@jklymak

[8]ページ先頭

©2009-2025 Movatter.jp