Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
ENH: Collection.set_paths#26342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
rcomer commentedJul 18, 2023
I have also tested this for the Cartopy case. |
lib/matplotlib/contour.py Outdated
| defset_paths(self,paths): | ||
| self._paths=paths | ||
| self.stale=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree with@anntzer's comment#26340 (comment)
I think we could just add this change toCollection.set_paths(paths) method definition instead so others can also subclass and take advantage of it (could remove the method definition fromPathCollection then too I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah sorry, I misread@anntzer's comment. I've now updatedCollection.set_paths. I left my test in becauseset_paths does not appear intest_collection.py. I assume theContourSet is as good a place as any to make sure this code path is covered?
PR summary
Closes#26340
I didn't add a changenote because I think this is covered by "Setting properties on the ContourSet can now usually be done using standard collection setters"
https://matplotlib.org/devdocs/api/next_api_changes/behavior/25247-AL.html
PR checklist