Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Only do pchanged and set stale when value changes + doc consistency#26326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 2 commits intomatplotlib:mainfromoscargus:artistprotection
Aug 9, 2023

Conversation

oscargus
Copy link
Member

PR summary

Original purpose was to not call pchanged or set stale to True if the value did not change (some set-methods already do this).

However, I found some doc inconsistencies so did a bit of search-and-replace as well...

PR checklist

self.pchanged()
self.stale = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For a follow-up PR I wonder if we should moveself.stale = True into thepchanged definition? It seems like every call topchanged is followed byself.stale = True...

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That can for sure be a good idea.

@oscargusoscargusforce-pushed theartistprotection branch 3 times, most recently from87098e3 to76fcf6eCompareJuly 17, 2023 12:36
@QuLogic
Copy link
Member

Hmm, most of this seems like it should be in#26334?

@oscargus
Copy link
MemberAuthor

Sort of. I stopped adding those here and started a new PR. I can possibly move individual files to that PR instead.

@oscargus
Copy link
MemberAuthor

oscargus commentedJul 19, 2023•
edited
Loading

I moved all files other than artist.py to#26334.

@tacaswelltacaswell added this to thev3.8.0 milestoneAug 9, 2023
@tacaswell
Copy link
Member

anyone can merge what green

@ksundenksunden merged commit7f843bb intomatplotlib:mainAug 9, 2023
@oscargusoscargus deleted the artistprotection branchAugust 9, 2023 20:57
@larsonerlarsoner mentioned this pull requestAug 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@greglucasgreglucasgreglucas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

5 participants
@oscargus@QuLogic@tacaswell@greglucas@ksunden
[8]ページ先頭
©2009-2025 Movatter.jp