Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

backend_qt4agg: remove redundant classes. Closes #1151.#2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
efiring merged 1 commit intomatplotlib:masterfromefiring:qt4agg_remove_unneeded
Nov 30, 2013

Conversation

efiring
Copy link
Member

No description provided.

@tacaswell
Copy link
Member

The_get_canvas function should also be removed frombackend_qt.NavigationToolbar2QT as it is never used.

It looks like it got copied over from the gtk backends when the QT ones were created. In gtk this function is used to set up the subplot tool.

travis failures look to all be pep8 blank-line issues.

efiring added a commit that referenced this pull requestNov 30, 2013
backend_qt4agg: remove redundant classes.Closes#1151.
@efiringefiring merged commitf226149 intomatplotlib:masterNov 30, 2013
@efiringefiring deleted the qt4agg_remove_unneeded branchNovember 30, 2013 18:30
@tacaswell
Copy link
Member

This probably should get an entry in api_changes.

Do we want to provide an alias to support 3rd party users who might be using it?

@tacaswelltacaswell mentioned this pull requestDec 5, 2013
9 tasks
@efiring
Copy link
MemberAuthor

@tacaswell, good point that it should have an api_changes entry; but I hope we can avoid putting in aliases.

@tacaswell
Copy link
Member

never mind, I can't read.

@tacaswell
Copy link
Member

Sorry for the noise, I miss read.

@tacaswell
Copy link
Member

And I was looking at the wrong example. Wedo use it in an example,http://matplotlib.org/examples/user_interfaces/embedding_in_qt4_wtoolbar.html , at least the toolbar should be depreciated gracefully.

@efiring
Copy link
MemberAuthor

@tacaswell Thanks for catching that; I was too hasty with the original PR. Both classes can be deprecated by subclassing, using warnings.warn with a mplDeprecation argument in theinit. It doesn't look like we have anything fancier than this for deprecating classes.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestDec 12, 2013
Added NavigationToolbar2QTAgg back with a deprecation warningAdded entry to api_changes.rst
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@efiring@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp