Where does theaxis on the spine get re-set to notNone?

Where does theaxis on the spine get re-set to notNone?

Thanks for the quick review, resetting the spine is indeed necessary. Not sure whether this is enough (I am still setting up tests locally), but the performance improvement seems worthwhile.

I'd just like to point out#26164.

@tacaswell Tests are passing now. The PR assumes the axis in the spines objects are the same as inself._axis_map. If this is not always the case, we could also do something like:

        cleared_axis = list( self._axis_map.values() )        for spine in self.spines.values():            # avoid expensive methods in the clearing of the spine, gh-26243                        tmp_axis = spine.axis            if tmp_axis in cleared_axis:                spine.axis = None            else:                 cleared_axis.append(tmp_axis)            spine.clear()            spine.axis = tmp_axis

@eendebakpt I think that the way this is addressed in#26164 is a better way to address this as it avoids patching monkeying with spine state (at the cost of a new private method).

@eendebakpt I think that the way this is addressed in#26164 is a better way to address this as it avoids patching monkeying with spine state (at the cost of a new private method).

I tested#26164 with the benchmark script from this PR and the performance gain is comparable. If that PR is merged, I will close this one.

Closing in favor of#26164