NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Re-export textpath types in text#26210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tacaswell merged 1 commit intomatplotlib:mainfromQuLogic:textpath-types

Jun 29, 2023

Merged

Re-export textpath types in text#26210

tacaswell merged 1 commit intomatplotlib:mainfromQuLogic:textpath-types

Jun 29, 2023

Conversation

Copy link

Member

QuLogic commentedJun 28, 2023

PR summary

The former location was deprecated in 3.7 (#23576), and accidentally removed earlier during some cleanup (#25787).

PR checklist

[n/a] "closes #0000" is in the body of the PR description tolink the related issue
[n/a] new and changed code istested
[n/a]Plotting related features are demonstrated in anexample
[n/a]New Features andAPI Changes are noted with adirective and release note
[n/a] Documentation complies withgeneral anddocstring guidelines

Re-export textpath types in text

5a736f3

The former location was deprecated in 3.7, and accidentally removedearlier during some cleanup.

QuLogic added the topic: typing label

Jun 28, 2023

QuLogic added this to thev3.8.0 milestone

Jun 28, 2023

ksunden approved these changes

Jun 28, 2023

View reviewed changes

tacaswell approved these changes

Jun 28, 2023

View reviewed changes

Copy link

Member

tacaswell commentedJun 28, 2023

Should he have expected stubtest to have caught this?

Copy link

Member

ksunden commentedJun 28, 2023

No, stubtest won't catch it because it ignores imported names (unless they are in__all__ or haveimport foo as foo)

I noted it in#25787 as something thatpycln did that I wanted to undo, but apparently missed actually undoing it like I did for the mathtext reexports.