Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
CI: Add pre-release installs to upcoming tests#26197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was thinking about doing exactly this in#26152, hopefully this would have caught it prior to final release...
(I do think there is an argument for some things to go even further and do git installs/get more things to upload nightlies, but this is (hopefully) better than not doing any pre releases... The particular change to pyparsing was actually made a year ago, but hadn't been released yet until recently... catching that sooner may have made it easier to sort out)
I went to look into this earlier, and when#19036 added GitHub Actions in parallel to TravisCI, it did not have nightly builds. I think I left it for later, but never did. When nightly builds were added in#21634, pre-releases were not added either. I'm not sure if we discussed this in a call, but I think Travis died a bit suddenly and we never remembered the pre-releases in the end. So I'm in favour of adding this here. |
Ah, there was a typo. Tests didn't run here, and raised an error when merged:
|
PR summary
There is a spot reserved for $PRE in the package installation command, but the environment variable doesn't appear to be set anywhere... Let's add it when we are doing our weekly scheduled runs to get other packages' pre-releases, not just the ones from pandas and numpy. Note this may cause more noise and be a little harder to track down where the issue is coming from, but seems like a good thing to do to test against other upcoming packages.