Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Sort tex2uni data in mathtext#26193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromdevRD:mt-tex2uni
Sep 1, 2023
Merged

Conversation

devRD
Copy link
Contributor

PR summary

Fixes#26029
Entries are converted to hex and the list is sorted on the LaTeX-strings

PR checklist

@devRDdevRD marked this pull request as ready for reviewJune 26, 2023 16:41
@oscargus
Copy link
Member

I wouldn't mind if#26173 and#26176 were merged first (there will be merge conflicts independent of order, but I hope that you have a script for this? Maybe that can be added as a comment in the file if it is short enough?).

devRD reacted with thumbs up emoji

@devRD
Copy link
ContributorAuthor

Sure this can wait for merging. I did use a script, I will update the code with the comment.
We can refactor any other changes if needed.

@oscargus
Copy link
Member

I think that this can be updated now.

'triangle' : 9651,
'iiiint' : 10764,
'amalg' : 10815,
'merge' : 10837,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is one fewer line in the new code, is something missing? (perhaps one of the things added by a recent PR?)

Copy link
Member

@oscargusoscargusSep 1, 2023
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Well spotted! I think that there is a duplicate in the above list.

In current mainlen(tex2uni) is 632 which is 1107-476+1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

And it wasn't that hard to find...

    'nsqsubseteq'              : 8930,    'nsqsupseteq'              : 8931,

devRD reacted with laugh emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

...but isn't it different:nsqSUBseteq andnsqSUPseteq(?)

oscargus reacted with confused emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is the duplicate entry in main:

oscargus reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, you right. I actually read it a few times...

@timhoffmtimhoffm added this to thev3.8.0 milestoneSep 1, 2023
@timhoffmtimhoffm merged commit05e164b intomatplotlib:mainSep 1, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 1, 2023
QuLogic added a commit that referenced this pull requestSep 1, 2023
…193-on-v3.8.xBackport PR#26193 on branch v3.8.x (Sort tex2uni data in mathtext)
@ksundenksunden mentioned this pull requestSep 15, 2023
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden left review comments

@oscargusoscargusoscargus approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

[MNT]: Unify tex2uni
4 participants
@devRD@oscargus@ksunden@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp