This sort of guarantees that (at least in a while), there will be no discrepancy between which symbols are supported and that those are supported correctly. That is, if a symbol is listed as a relational operator, there will be spaces surrounding it.

Also adds a few new sections to the supported symbols list. Not sure if "Western Europe" is the best description for å, Å etc (although they are used in Swedish and some of the other are used in Norwegian etc.).

Listed directly supported script, fraktur and black board characters. If nothing else to see which works and which should maybe be added...

The ones that are not yet added are:

vec = ⃗textasciicircum = ^imageof = ⊷origof = ⊶solbar = ⌿k = ̨textexclamdown = ¡llcorner = ⌞invnot = ⌐lq = ‘greater = >lrcorner = ⌟not = ̸bar = ̄rightharpoonaccent = ⃑textasciitilde = ~leftharpoonaccent = ⃐carriagereturn = ↵overarc = ̑candra = ̐quad =  minus = −kernelcontraction = ∻spadesuitopen = ♤textquotedblleft = “grave = ̀acwopencirclearrow = ↺dot = ̇turnednot = ⌙rasp = ʼH = ̋ulcorner = ⌜underbar = ̱lasp = ʽc = ̧colon = :textasciiacute = ´breve = ̆textquestiondown = ¿__sqrt__ = √emdash = —less = <tilde = ̃textasciigrave = `smallsetminus = ∖cdotp = ·hat = ̂acute = ́d = ̣t = ͡dddot = ⃛ocirc = ̊ddddot = ⃜thickspace =  endash = –urcorner = ⌝prurel = ⊰ddot = ̈check = ̌rq = ’textquotedblright = ”% = %_ = _# = #guillemotleft = «ring = ˚guilsinglright = ›macron = ¯guillemotright = »asterisk = *guilsinglleft = ‹plus = +smallintclockwise = ∱smallvarointclockwise = ∲smallointctrcclockwise = ∳

The accents should probably be removed as they are handled separately. For exampleddot is mapped tocombiningdiaeresis.

Then, one may wonder if we want to openly state that we support\plus rather than simply using+?

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

oscargus added Documentation topic: text/mathtext labels

Jun 23, 2023

Copy link

MemberAuthor

oscargus commentedJun 23, 2023

Another change is that the extension prints the rendered symbols as above. Which clearly showed thatleftbrace had the wrong mapping.

Copy link

MemberAuthor

oscargus commentedJun 23, 2023

The failing test is because mathtext adds space around the "spaced operators" in subscripts as well, while LaTeX doesn't. (\to was not in the list of arrows, but should be spaced in normal size.)

oscargus mentioned this pull request

Jun 23, 2023

[Bug]: Spaced symbols should not be spaced when in limits etc#26174

Open

Copy link

MemberAuthor

oscargus commentedJun 23, 2023•
edited
Loading

Here is the outcome:https://output.circle-artifacts.com/output/job/0c35025a-735d-4800-a574-b790431306bd/artifacts/0/doc/build/html/users/explain/text/mathtext.html

A bit annoyingly *, +, and - are all interpreted as list bullets...

oscargus mentioned this pull request

Jun 23, 2023

Add more sizeable delimiters#26176

Merged

5 tasks

oscargus force-pushed thesymboldocs branch fromf492164 toa667d19Compare

June 23, 2023 15:21

github-actionsbot added the status: needs rebase label

Jun 24, 2023

oscargus force-pushed thesymboldocs branch froma667d19 tocd8cfdcCompare

June 24, 2023 13:05

github-actionsbot removed the status: needs rebase label

Jun 24, 2023

oscargus force-pushed thesymboldocs branch 4 times, most recently from7abdc11 to8f656baCompare

June 24, 2023 15:42

oscargus added this to thev3.8.0 milestone

Jun 26, 2023

This was referencedJun 26, 2023

Sort tex2uni data in mathtext#26193

Merged

Dynamically calculating columns on Math symbols#26191

Closed

Copy link

Member

QuLogic commentedJul 6, 2023

A bit annoyingly *, +, and - are all interpreted as list bullets...

Should maybe be fixed? Perhaps a backslash prefix will work?

QuLogic reviewed

Jul 6, 2023

View reviewed changes

doc/sphinxext/math_symbol_table.py

		_mathtext.Parser._arrow_symbols],
		["Dot symbols",
		4,
		r"""\cdots \vdots \ldots \ddots \adots \Colon \therefore \because""".split()],

Copy link

Member

QuLogicJul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Aren'ttherefore andbecause in Relation operators?

Copy link

MemberAuthor

oscargusJul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, they are. As well.

I just saw some table with "dot symbols" somewhere (do not remember where, maybe the "List of LaTeX symbols..." or whatever it is called), where they were included, so thought that it may make sense. Easy to modify though.

Copy link

MemberAuthor

oscargus commentedJul 7, 2023

Should maybe be fixed? Perhaps a backslash prefix will work?

Indeed. Just had no idea how to obtain it. Have tried to read up, but haven't found anything. I guess making an HTML table directly is a way to go though?

Copy link

Member

QuLogic commentedJul 7, 2023

Usually, a backslash before characters will stop reST from treating them as whatever markup, so pretty sure that'll work for the bullets as well.

oscargus force-pushed thesymboldocs branch 2 times, most recently fromd52726a tod7f95e6Compare

July 13, 2023 02:20

Copy link

MemberAuthor

oscargus commentedJul 13, 2023

Fixed. Seems to work.

Synchronize mathtext docs and handling

fcf75dd

oscargus force-pushed thesymboldocs branch fromd7f95e6 tobdd8df3Compare

July 22, 2023 08:50

ksunden modified the milestones:v3.8.0,v3.8-doc

Aug 8, 2023

oscargus removed this from thev3.8-doc milestone

Aug 9, 2023

oscargus added this to thev3.8.0 milestone

Aug 9, 2023

Copy link

MemberAuthor

oscargus commentedAug 9, 2023

I think this should go in 3.8 since there are "half-made" changes towards this and this is the final step.

tacaswell reviewed

Aug 9, 2023

View reviewed changes

lib/matplotlib/_mathtext_data.py

		'O' :216,
		'hookleftarrow' :8617,
		'trianglerighteq' :8885,
		'nsime' :8772,

Copy link

Member

tacaswellAug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Has this just been wrong from 2006 ?!

Copy link

MemberAuthor

oscargusAug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess so. However, I do not think it was documented so I wonder if someone ever used it?

tacaswell approved these changes

Aug 9, 2023

View reviewed changes

Copy link

Member

tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have some concern about thensime ->nsimeq change, however it appears thatnsimeq is the correct symbol.

https://milde.users.sourceforge.net/LUCR/Math/mathpackages/txfonts-symbols.pdf

If we need an API change note, we can add that in a follow up PR.

ksunden previously requested changes

Aug 9, 2023

View reviewed changes

lib/matplotlib/_mathtext_data.py

		'hermitmatrix' :8889,
		'barvee' :8893,
		'measuredrightangle' :8894,
		'varlrtriangle' :8895,

Copy link

Member

ksundenAug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks to have been correct?lrtriangle is U+25ff (9727) andvarlrtriangle is U+22bf (8895).

reference:https://ctan.mirrors.hoobly.com/fonts/stix/doc/stix.pdf

Both are triangles, but stix assigns this the same as the old name

ksunden reviewed

Aug 9, 2023

View reviewed changes

lib/matplotlib/_mathtext_data.py Outdated

		'barvee' :8893,
		'measuredrightangle' :8894,
		'varlrtriangle' :8895,
		'lrtriangle' :8895,

Copy link

Member

ksundenAug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	'lrtriangle' :8895,
	'varlrtriangle' :8895,

Copy link

MemberAuthor

oscargusAug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'll add lrtriangle then. DIdn't make sense to have varlrtriangle if we don't have lrtriangle...

Copy link

MemberAuthor

oscargusAug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm wondering if one should script the source of the STIX documentation and add all those symbols? The problem is just to add them to the documentation...

Copy link

MemberAuthor

oscargusAug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reverted to varlrtriangle. Any additional symbols will be in another PR.

oscargus force-pushed thesymboldocs branch frombdd8df3 tob15872dCompare

August 10, 2023 17:56

tacaswell reviewed

Aug 10, 2023

View reviewed changes

lib/matplotlib/_mathtext.py

		\cup \triangleright \ddagger
		\uplus \lhd \amalg
		\dotplus \dotminus'''.split())
		\dotplus \dotminus \Cap

Copy link

Member

tacaswellAug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is going to change how some things render, do we need a note about this?

oscargus force-pushed thesymboldocs branch fromb15872d to655ec51Compare

August 10, 2023 19:13

ksunden dismissed theirstale review

August 10, 2023 19:38

changes addressed

Copy link

Member

ksunden commentedAug 10, 2023

The doc build seems to still be gettinglrtriangle instead ofvarlrtriangle

Seems to be due to

matplotlib/doc/sphinxext/math_symbol_table.py

Lines 79 to 80 in655ec51

	ifignore_variantandsym!=r"\varnothing":
	sym=sym.replace(r"\var","\\")

Probably the thing to do is to add just this one here.

Copy link

MemberAuthor

oscargus commentedAug 10, 2023

Ah, that may have been an additional reason for the name change...

Do not space symbols in limits

ee02182

oscargus force-pushed thesymboldocs branch from655ec51 toee02182Compare

August 10, 2023 22:23

Copy link

MemberAuthor

oscargus commentedAug 12, 2023

This is updated

ksunden approved these changes

Aug 14, 2023

View reviewed changes

ksunden merged commitac95c22 intomatplotlib:main

Aug 14, 2023

meeseeksmachine mentioned this pull request

Aug 15, 2023

Backport PR #26173 on branch v3.8.x (Synchronize mathtext docs and handling)#26527

Merged

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request

Aug 15, 2023

Backport PRmatplotlib#26173: Synchronize mathtext docs and handling

5d59820

ksunden added a commit that referenced this pull request

Aug 15, 2023

Merge pull request#26527from meeseeksmachine/auto-backport-of-pr-26…

7ecea2a

…173-on-v3.8.xBackport PR#26173 on branch v3.8.x (Synchronize mathtext docs and handling)

oscargus deleted the symboldocs branch

August 16, 2023 08:59

ksunden mentioned this pull request

Sep 15, 2023

merge up v3.8.0#26785

Merged

5 tasks

Labels

Documentation topic: text/mathtext

Movatterモバイル変換

Uh oh!

Synchronize mathtext docs and handling#26173

Synchronize mathtext docs and handling#26173

Uh oh!

Conversation

oscargus commentedJun 23, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR summary

PR checklist

Uh oh!

oscargus commentedJun 23, 2023

Uh oh!

oscargus commentedJun 23, 2023

Uh oh!

oscargus commentedJun 23, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

QuLogic commentedJul 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oscargus commentedJul 7, 2023

Uh oh!

QuLogic commentedJul 7, 2023

Uh oh!

oscargus commentedJul 13, 2023

Uh oh!

oscargus commentedAug 9, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tacaswell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ksunden commentedAug 10, 2023

Uh oh!

oscargus commentedAug 10, 2023

Uh oh!

oscargus commentedAug 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oscargus commentedJun 23, 2023•
edited
Loading

oscargus commentedJun 23, 2023•
edited
Loading