Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

precommit warns on main + instructions for fix#26171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromstory645:branch_protect
Jun 27, 2023

Conversation

story645
Copy link
Member

@story645story645 commentedJun 23, 2023•
edited
Loading

Added a branch protect rule to the pre-commit so that it complains if you try to commit directly to main. I figure folks who really need to push to main also know how to work around it. based on convo in call w/@greglucas

Not quite sure this is the best way to handle the error message but figure we need to give folks a fix.

Is a replacement for#26170 which I'm not sure how I accidentally created directly on the repo.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, you managed to beat me to the PR.

@story645
Copy link
MemberAuthor

😅 you're welcome to take over

@story645story645force-pushed thebranch_protect branch 2 times, most recently from1384342 to28d6a26CompareJune 23, 2023 02:50
@story645
Copy link
MemberAuthor

do not love that this is running away from me/growing in scope, but since it is are there any other branches that I should include? (like doc or whatever) or is main the only one that's a problem.

@story645
Copy link
MemberAuthor

So this pr now has:
1: precommit hook with short message
2: action with longer message - not totally sure it works or should fail
3. updated docs about branches on main

@story645story645force-pushed thebranch_protect branch 2 times, most recently from8631d19 to34d8fc3CompareJune 23, 2023 19:24
@story645story645force-pushed thebranch_protect branch 2 times, most recently from617c465 todf6331dCompareJune 25, 2023 17:08
Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor corrections.

+ instructions for fix in docsCo-authored-by: Greg Lucas <greg.m.lucas@gmail.com>Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogicQuLogic merged commit11a5d66 intomatplotlib:mainJun 27, 2023
@QuLogicQuLogic added this to thev3.8.0 milestoneJun 27, 2023
@story645story645 deleted the branch_protect branchOctober 6, 2023 16:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@melissawmmelissawmmelissawm left review comments

@rcomerrcomerrcomer left review comments

@QuLogicQuLogicQuLogic approved these changes

@greglucasgreglucasgreglucas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

5 participants
@story645@QuLogic@melissawm@rcomer@greglucas
[8]ページ先頭
©2009-2025 Movatter.jp