Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Tst/restore old tests#26131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 3 commits intomatplotlib:mainfromtacaswell:tst/restore_old_tests
Mar 22, 2024
Merged

Conversation

tacaswell
Copy link
Member

PR summary

In7b71257 via#4843 I intended to revert the changes from#4019 however, I incorrectly resolved the merge conflicts and also removed the tests added in#4023 and#4342.

This is attempting to put them back. There are two complications:

  • we have made changes to the text baseline calculations so the test images need to be regenerated
  • The test marked as xfail is anAnnotation defaulting to data coordinates when added directly to aFigure that does not have an Axes. I'm not clear why this ever worked (we must have had more complicated default coordinate behavior?!).

I found this issue while looking at what images were in our repo that were not generated by running the test suite.

@tacaswelltacaswell added this to thev3.8.0 milestoneJun 15, 2023
@QuLogic
Copy link
Member

The test marked as xfail is anAnnotation defaulting to data coordinates when added directly to aFigure that does not have an Axes. I'm not clear why this ever worked (we must have had more complicated default coordinate behavior?!).

Addingxycoords='figure pixels' orxycoords='figure points' seems to work?

@QuLogic
Copy link
Member

It looks liketest_font_wrap[png] is failing, though not everywhere.

…_neg_coords""This partially reverts commit7b71257.Too many tests were removed, restore the extra tests.
Remove the light font because we don't have a good one on mac on CI
@ksundenksunden merged commit47c96df intomatplotlib:mainMar 22, 2024
@tacaswelltacaswell deleted the tst/restore_old_tests branchMarch 22, 2024 13:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.

3 participants
@tacaswell@QuLogic@ksunden
[8]ページ先頭
©2009-2025 Movatter.jp