Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow separate config of minor grid params in matplotlibrc.#26121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
RJTK wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromRJTK:grid-minor-rcparams

Conversation

RJTK
Copy link

PR summary

Addsgrid.minor.* params tomatplotlibrc allowing one to set different parameters for minor grids. I've been manually turning on minor ticks with.grid(which="minor"), but this gets tiring and I'd like to be able to just enable this globally in thematplotlibrc file. However, both themajor andminor parameters are currently configured withgrid.*, with no distinction forminor ormajor. The present PR attempts to address this.

I can add examples / test / docs etc. if this might be an acceptable change.

PR checklist

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@RJTK
Copy link
Author

RJTK commentedAug 5, 2023

Is there interest in this?

@jklymak
Copy link
Member

It seems ok but is a breaking change for any style that customized the grid style and expected the minor grid to change as well?

@QuLogic
Copy link
Member

Yes, thegrid.minor.* rcParams should probably default to something (name to be determined) that indicates it should fall back to the original major grid'sgrid.* rcParams version.

@QuLogic
Copy link
Member

cc@timhoffm on that.

@RJTK
Copy link
Author

RJTK commentedAug 6, 2023

Yes, the grid.minor.* rcParams should probably default to something (name to be determined) that indicates it should fall back to the original major grid's grid.* rcParams version.

Agreed, I can update to ignore the .minor.* param unless explicitly set.

@timhoffm
Copy link
Member

I think the pragmatic approach here is do use "inherit" as a default value and if that is encountered, use the respective non-minor grid value.

This also rhymes with the layering hierarchy that (major) is undergrid.* and minor is one level below undergrid.minor.*.

A revised config framework may add reusing other values within the config classes as well, but for now, the pragmatic solution is to hard-code that inheritance at the usage sites ofgrid.minor.

RJTK reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Projects
Status: Waiting for author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@RJTK@jklymak@QuLogic@timhoffm@melissawm

[8]ページ先頭

©2009-2025 Movatter.jp