Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: Handle masked arrays for RGBA input with ScalarMappables#26096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This needs an API change note.
I'm sure we have at least one user who is relying on the mask being ignored!
I do not think this needs a deprecation cycle (as I suspect "just document it" was to avoid fixing a bug).
This sets the alpha channel to 0 when any RGB(A) input is masked.
👍 Added a change note now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for doing this@greglucas!
I have also verified that it enables the hoped for simplification of my Cartopy branch.
PR summary
Currently, the mask is ignored if a user passes in RGB(A) input arrays. This sets the alpha channel to 0 when any RGB(A) input is masked. This is relevant for RGB(A) data being used with pcolormesh. xref:SciTools/cartopy#2166 where it will simplify downstream accounting for masks and alpha.
PR checklist