Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactor axislines nth_coord#26066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
oscargus wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromoscargus:axislines

Conversation

oscargus
Copy link
Member

PR summary

PR checklist

@oscargusoscargus marked this pull request as ready for reviewJune 4, 2023 14:27
@anntzer
Copy link
Contributor

Does that really need a public setter? Is there any of the downstream code that could reasonably make use of that functionality? Does the rest of the code even work (eg are caches invalidated properly) if you change nth_coord?

If anything it make make more sense to deprecate direct attribute access to make that immutable. (I'm not sure any of the downstream code even really needs access to that...)

@oscargus
Copy link
MemberAuthor

Good question. The main thing was really to move the common get_nth_coord and then the rest just followed.

There is an example for a private method (replying from the phone...) where it is changed, but I haven't checked more.

You are probably correct that it may make more sense to make it a private attribute. Will have a further look at it.

@oscargusoscargus marked this pull request as draftJune 4, 2023 18:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@oscargus@anntzer

[8]ページ先頭

©2009-2025 Movatter.jp