Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Refactor axislines nth_coord#26066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Does that really need a public setter? Is there any of the downstream code that could reasonably make use of that functionality? Does the rest of the code even work (eg are caches invalidated properly) if you change nth_coord? If anything it make make more sense to deprecate direct attribute access to make that immutable. (I'm not sure any of the downstream code even really needs access to that...) |
Good question. The main thing was really to move the common get_nth_coord and then the rest just followed. There is an example for a private method (replying from the phone...) where it is changed, but I haven't checked more. You are probably correct that it may make more sense to make it a private attribute. Will have a further look at it. |
PR summary
PR checklist