Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Pass on prop to parent in AnchoredDrawingArea#26059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Conceptually this is correct, though I wonder whether we should deprecate AnchoredDrawingArea/AnchoredAuxTransformBox for reasons similar to#25781 (the use case is more real, but there isn't really any benefit in squashing together the args of the two constructors -- you more or less need to understand how the two component classes (AnchoredOffsetbox & DrawingArea/AuxTransformBox) work to make use of the composite class. |
I cannot say that I fully checked the surrounding code, just happened to notice that But checking a bit more carefully I can agree that the benefit of having these wrapper classes is limited. |
PR summary
Not sure if this is the right way to do it, but otherwise prop is unused... (It has been like this since the code first got in...)
PR checklist