Previously, collections would return a "cycled" version of linewidths which is internally used to scale dashes (this scaling needs to be done at property setting time, because of the interaction with styles).

While it makes sense to store the cycled scaled dashes, there's no need to also store the cycled linewidths or pass that to the backend code -- directly using the uncycled linewidths seems simpler. This also makes collection.get_linewidths() return something much closer to whatever was passed in -- see the test change in test_lslw_bcast.

Also, "broadcasting" has a technical meaning in numpy; it's not the same thing as cycling.

PR summary

PR checklist

"closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
Plotting related features are demonstrated in anexample
New Features andAPI Changes are noted with adirective and release note
Documentation complies withgeneral anddocstring guidelines

Let collections return linewidths "as is", without cycling.

52cb1e0

Previously, collections would return a "cycled" version of linewidthswhich is internally used to scale dashes (this scaling needs to be doneat property setting time, because of the interaction with styles).While it makes sense to store the cycled scaled dashes, there's no needto also store the cycled linewidths or pass that to the backend code --directly using the uncycled linewidths seems simpler.  This also makescollection.get_linewidths() return something much closer to whatever waspassed in -- see the test change in test_lslw_bcast.

anntzer added the topic: collections and mappables label

Jun 2, 2023

Copy link

Member

oscargus commentedJun 2, 2023

If we are to change the return values of these things, I'd like to chip in#23056 I foresee a major rebase effort if this goes in before (although I may be wrong).

Copy link

ContributorAuthor

anntzer commentedJun 2, 2023

I don't really mind either way, though I'd say the change here (making get_linewidths() return something closer to what was passed in) is more useful than the change in#23056 (which makes get_linestyle() return something different from what was passed in, if I understand it correctly). (Notwithstanding the other benefits of#23056.)